Skip to content

Java 17 support #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ostinru wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Java 17 support #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
226de16
cd server && ./gradlew wrapper --gradle-version 7.6
ostinru Feb 1, 2026
ba075a5
Update lombok plugin to recommended by authors
ostinru Feb 1, 2026
29ca443
Add `-Xlint:-removal` to skip warning about package removal. (With -W…
ostinru Feb 1, 2026
82815ec
JEP486: add --add-opens to tests, so it still works
ostinru Feb 1, 2026
85ceddb
bump other gradle dependencies
ostinru Feb 1, 2026
d53778e
Add to CI
ostinru Feb 1, 2026
49c9327
Add --add-opens to start script
ostinru Feb 12, 2026
217094c
Move java version compatibility test to CI & remove junit tests from …
ostinru Mar 1, 2026
6ab2388
gradle 7.x support only java 19
ostinru Mar 1, 2026
6b2d3f3
remove junit tests from automation flow - it duplicates java version …
ostinru Mar 1, 2026
610404b
review
ostinru Mar 5, 2026
1cf7719
review v2
ostinru Mar 9, 2026
3a90dd7
Add Gradle Wrapper Validation to build pipeline (as apache/calcite does)
ostinru Mar 16, 2026
99bf4bf
Remove gradle-wrapper validation - we don't keep binary in the source…
ostinru Mar 18, 2026
cb0a981
user make in all tests (we don't have gradle wrapper anymore)
ostinru Mar 18, 2026
f936ee0
better
ostinru Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/pxf-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,23 @@ jobs:
path: /tmp/singlecluster-image.tar
retention-days: 1

java-compatibility-test:
name: build-and-test with java v${{ matrix.java }}
runs-on: ubuntu-latest
strategy:
matrix:
java: [ '8', '11', '17' ]
Copy link
Collaborator

@MisterRaindrop MisterRaindrop Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ matrix.Java } I see the task is already running, which means both uppercase and lowercase are fine. However, it seems like the inconsistency in capitalization might look better if unified. Of course, this is just a suggestion.

Copy link
Collaborator Author

@ostinru ostinru Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for thoughtful review!

fail-fast: false
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'corretto'
- name: Assemble and test with Gradle
working-directory: ./server
run: make test

# Stage 2: Parallel test jobs using matrix strategy
pxf-test:
name: Test PXF - ${{ matrix.test_group }}
Expand All @@ -125,7 +142,6 @@ jobs:
- cli
- external-table
- fdw
- server
- sanity
- smoke
- hdfs
Expand Down
10 changes: 5 additions & 5 deletions ci/docker/pxf-cbdb-dev/ubuntu/script/build_pxf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ export PXF_HOME=/usr/local/pxf
sudo mkdir -p "$PXF_HOME"
sudo chown -R gpadmin:gpadmin "$PXF_HOME"

# Build all PXF components
make all

# Install PXF
make install
# Build and Install PXF
make -C external-table install
make -C fdw install
make -C cli install
make -C server install-server

# Set up PXF environment

Expand Down
12 changes: 9 additions & 3 deletions server/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ buildscript {
}

plugins {
id "io.franzbecker.gradle-lombok" version "3.3.0"
id "io.freefair.lombok" version "6.6.3"
id "org.springframework.boot" version "${springBootVersion}" apply false
id 'io.spring.dependency-management' version '1.0.11.RELEASE'
id 'io.spring.dependency-management' version '1.0.15.RELEASE'
}

// override Spring Framework version to pick the Spring MVC 5.3.33 with the async race condition fix
Expand Down Expand Up @@ -59,7 +59,7 @@ idea {
configure(javaProjects) {
apply plugin: 'java'
apply plugin: 'io.spring.dependency-management'
apply plugin: "io.franzbecker.gradle-lombok"
apply plugin: "io.freefair.lombok"

group = 'org.apache.cloudberry.pxf'
version = "${version}"
Expand Down Expand Up @@ -258,6 +258,9 @@ configure(javaProjects) {
"-Xlint:empty", "-Xlint:finally", "-Xlint:overrides", "-Xlint:path", "-Xlint:-processing", "-Xlint:static",
"-Xlint:try", "-Xlint:fallthrough", "-Xlint:unchecked", "-Xlint:-options", "-Werror"
]
// JEP 411 (Java 17) - java.security.AccessController is deprecated.
// Note, in JEP 486 (Java 24) Security Manager is completely disabled, however Java-API is not broken.
options.compilerArgs += JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17) ? ["-Xlint:-removal"] : []
}

compileTestJava {
Expand All @@ -266,6 +269,9 @@ configure(javaProjects) {
"-Xlint:empty", "-Xlint:finally", "-Xlint:overrides", "-Xlint:path", "-Xlint:-processing", "-Xlint:static",
"-Xlint:try", "-Xlint:fallthrough", "-Xlint:unchecked", "-Xlint:-options", "-Werror"
]
// JEP 411 (Java 17) - java.security.AccessController is deprecated.
// Note, in JEP 486 (Java 24) Security Manager is completely disabled, however Java-API is not broken.
options.compilerArgs += JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17) ? ["-Xlint:-removal"] : []
}

configurations {
Expand Down
1 change: 0 additions & 1 deletion server/gradle/wrapper/gradle-6.8.2-wrapper.jar.sha256
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions server/gradle/wrapper/gradle-7.6.6-wrapper.jar.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
14dfa961b6704bb3decdea06502781edaa796a82e6da41cd2e1962b14fbe21a3
5 changes: 3 additions & 2 deletions server/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.6-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionSha256Sum=8de6efc274ab52332a9c820366dd5cf5fc9d35ec7078fd70c8ec6913431ee610
distributionSha256Sum=673d9776f303bc7048fc3329d232d6ebf1051b07893bd9d11616fad9a8673be0
Loading
Loading