Open
Conversation
Contributor
|
Thanks David, start this pull request. please also remove the old spark version integration code. |
jackylk
reviewed
Apr 14, 2024
| <groupId>org.apache.thrift</groupId> | ||
| <artifactId>libthrift</artifactId> | ||
| <version>0.9.3</version> | ||
| <version>0.19.0</version> |
Contributor
There was a problem hiding this comment.
It is better we do this in another PR. I am preparing a PR for this.
739a5b1 to
cb96c8b
Compare
Contributor
|
please solve some conflicts. |
e8c4ae8 to
122a544
Compare
Contributor
|
@QiangCai I saw you submitted 5 commits to community in last week, please let us know the latest progress about this PR |
jackylk
reviewed
Apr 29, 2025
| </properties> | ||
| </profile> | ||
| <profile> | ||
| <id>spark-2.3</id> |
Contributor
There was a problem hiding this comment.
Is these removal reqired? All spark profile is removed
jackylk
reviewed
May 4, 2025
| <httpclient.version>4.5.14</httpclient.version> | ||
| <httpcore.version>4.4.16</httpcore.version> | ||
| <scala.binary.version>2.12</scala.binary.version> | ||
| <scala.version>2.12.18</scala.version> |
Contributor
There was a problem hiding this comment.
从Spark 3.5开始,好像要依赖Java 21? 你是用Java 21编译的吗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
What changes were proposed in this PR?
Does this PR introduce any user interface change?
Is any new testcase added?