Bigtable: skip reading large rows

[mutianf]

Add an option to skip reading large rows. The large rows will be logged as warnings.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @mutianf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an experimental feature for the Apache Beam Bigtable I/O connector, allowing users to configure the Bigtable client to skip excessively large rows during read operations. This enhancement aims to improve the robustness and efficiency of pipelines by preventing failures or performance degradation caused by individual rows that exceed typical processing capacities, offering a graceful way to handle such data anomalies.

Highlights

• New Experimental Option: Introduced a new experimental option, bigtable_enable_skip_large_rows, to control the behavior of skipping large rows during Bigtable reads.
• Bigtable Service Integration: Modified BigtableServiceFactory to detect the bigtable_enable_skip_large_rows experiment and pass this configuration to the BigtableServiceImpl.
• Conditional Row Skipping Logic: Updated BigtableServiceImpl to include a skipLargeRows flag, which, when enabled, instructs the Bigtable client to use a specialized skipLargeRowsCallable for reading, effectively ignoring rows exceeding a certain size.
• Integration Test for Skipping Large Rows: Added an end-to-end integration test in BigtableReadIT to validate that when the bigtable_enable_skip_large_rows experiment is active, large rows are indeed skipped during Bigtable read operations.
• Unit Test Adaptation: Adjusted BigtableServiceImplTest to accommodate the new constructor parameter for BigtableServiceImpl.BigtableReaderImpl, ensuring existing tests remain functional.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java
  • Added a new constant BIGTABLE_ENABLE_SKIP_LARGE_ROWS.
  • Modified getServiceForReading to check for the new experimental option and pass it to the BigtableServiceImpl constructor.
• sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java
  • Added a skipLargeRows field and a new constructor to BigtableServiceImpl.
  • Updated the existing BigtableServiceImpl constructor to delegate to the new one with skipLargeRows set to false.
  • Modified BigtableReaderImpl to store the skipLargeRows flag.
  • Updated BigtableReaderImpl.start() to conditionally use client.skipLargeRowsCallable() or client.readRowsCallable() based on the skipLargeRows flag.
• sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java
  • Added new imports for Bigtable client and Beam SDK components.
  • Implemented testE2EBigtableReadWithSkippingLargeRows to verify the large row skipping functionality.
• sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImplTest.java
  • Updated the BigtableReaderImpl constructor call in testRead to include the new skipLargeRows parameter, set to false.

Activity

• No human activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers