-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Exercise Python PVR test on Flink 2.0 #37313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing the build environment and continuous integration (CI) for Apache Flink 2.0. It refines the Gradle build configuration to dynamically manage Flink versions, specifically enabling the system to recognize Flink 2.0 as the latest version. Additionally, various CI trigger files have been updated, including the introduction of new Flink-related test triggers, to ensure comprehensive testing with the anticipated Flink 2.0 integration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
PostCommit Java Nexmark Flink: https://github.com/apache/beam/actions/runs/21644527625 PostCommit Java PVR Flink Streaming: https://github.com/apache/beam/actions/runs/21644546969 PostCommit Java ValidatesRunner Flink: https://github.com/apache/beam/actions/runs/21644604617 |
1565d23 to
2c39771
Compare
|
Current test failures: problems related to side input https://github.com/apache/beam/actions/runs/21840420138/job/63022922889 |
| environment_type: ['DOCKER', 'LOOPBACK'] | ||
| # all environment_type: ['DOCKER', 'LOOPBACK', 'PROCESS'] | ||
| # Run modes not covered by PreCommit_Python_PVR_Flink (i.e. other than 'LOOPBACK') | ||
| environment_type: ['DOCKER'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOOPBACK for both Flink 1.20 and Flink 2.0 already have coverage, dedup'd here
| manifest { | ||
| attributes(["Multi-Release": true]) | ||
| } | ||
| outputs.upToDateWhen { false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a workaround leftover for corrupted remote Gradle cache, could cause elevated compile time.
| return [ | ||
| 'java', | ||
| '-XX:-UseContainerSupport', | ||
| return ['java'] + platform_specific_opts + [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix flink_runner_test on MacOS (and persumably windows)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37313 +/- ##
=============================================
+ Coverage 35.88% 54.88% +18.99%
Complexity 1691 1691
=============================================
Files 1063 1063
Lines 166668 166741 +73
Branches 1227 1227
=============================================
+ Hits 59804 91509 +31705
+ Misses 104665 73035 -31630
+ Partials 2199 2197 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Flink 2 Tests passed: PreCommit Python PVR Flink (runs Flink 2 LOOPBACK): https://github.com/apache/beam/actions/runs/21971664799 PostCommit Python Portable Flink (runs Flink 2 DOCKER): |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Please add a meaningful description for your change here
Fix #37583
Part of #36947
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.