Fix serialization unit tests to avoid ORM side effects in --skip-db-tests mode#65206
Open
holmuk wants to merge 1 commit intoapache:mainfrom
Open
Fix serialization unit tests to avoid ORM side effects in --skip-db-tests mode#65206holmuk wants to merge 1 commit intoapache:mainfrom
holmuk wants to merge 1 commit intoapache:mainfrom
Conversation
1 task
Collaborator
|
To be safe, I added a tag to run more tests to make sure nothing unrelated broke as a result of these changes. These will run on the next rebase or after close/reopen. |
ebd4aeb to
546eaa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
airflow-core/tests/unit/serialization/test_serialized_objects.py, some ORM models (TaskInstance,DagRun,Connection) were instantiated at module import time. In--skip-db-testsmode, Airflow intentionally disables DB setup, so these import-time ORM side effects triggered SQLAlchemy mapper initialization and caused collection-time failures.This PR resolves this issue:
test_serialized_objects.pyto make--skip-db-testsdeterministicTaskInstancetest payload intest_serialize_deserializeparameters with globalTaskInstancedatamodelConnectionserialization coverage into dedicated@pytest.mark.db_testtests (test_serialize_deserialize_connection)test_backcompat_deserialize_connectionasdb_testbecause it creates ORMConnectionclassWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.