Fix bulk connection delete banner#64735
Open
shubhamraj-git wants to merge 1 commit intoapache:mainfrom
Open
Conversation
shubhamraj-git
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton and
vatsrahul1001
as code owners
shivaam
reviewed
Apr 5, 2026
| }), | ||
| title: translate("toaster.bulkDelete.success.title"), | ||
| title: translate("toaster.bulkDelete.success.title", { | ||
| resourceName: translate("admin:connections.connection_other"), |
Contributor
There was a problem hiding this comment.
nit: consider translate("admin:connections.connection", { count: success.length }) here (and for the description's resourceName above) to match the count-driven plural pattern used by DataTable elsewhere in the UI. It would make the toast grammatically correct for n=1 and for languages with richer plural forms. Since the function is available, seems worth using it
eladkal
added
the
backport-to-v3-2-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue -