Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount#64730
Draft
Miretpl wants to merge 5 commits intoapache:mainfrom
Draft
Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount#64730Miretpl wants to merge 5 commits intoapache:mainfrom
Miretpl wants to merge 5 commits intoapache:mainfrom
Conversation
2 tasks
2ce973f to
bcbbe1f
Compare
bcbbe1f to
bb36637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #28880
This PR introduces two new sections:
workers.celery.serviceAccountandworkers.kubernetes.serviceAccount. Theworkers.serviceAccountsection is now deprecated.In terms of logic, it works a little differently than other fields/sections moved to the
workers.celery/workers.kubernetessection. All fields underworkers.celeryoverride values underworkerssection, but whenworkers.kubernetessection is used, the Service Account is generated fromtemplates/workers/worker-kubernetes-serviceaccount.yamlfile instead oftemplates/workers/worker-serviceaccount.yaml. Despite that separation, some fields have fallbacks to theworkerssection to match behaviour of other, already moved, fields/sections.Additional change - all
ServiceAccountwas changed toService Accountinvalues.yamlas that was missed.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.