Add TriggerNode component with i18n support for graph view#64689
Open
windro-xdd wants to merge 1 commit intoapache:mainfrom
Open
Add TriggerNode component with i18n support for graph view#64689windro-xdd wants to merge 1 commit intoapache:mainfrom
windro-xdd wants to merge 1 commit intoapache:mainfrom
Conversation
- Add new TriggerNode.tsx component for rendering trigger nodes - Register TriggerNode in graphTypes.ts nodeTypes - Add 'triggerDagRun' translation key to all locale files (21 languages) - Add 'sensor' node type registration for consistency
windro-xdd
requested review from
BasPH,
Lee-W,
ashb,
bbovenzi,
bugraoz93,
choo121600,
guan404ming,
hussein-awala,
jason810496,
jscheffl,
mobuchowski,
pierrejeambrun,
potiuk,
romsharon98,
ryanahamilton,
sekikn,
shahar1,
shubhamraj-git,
uranusjr,
vatsrahul1001 and
vincbeck
as code owners
boring-cyborg
bot
added
area:translations
area:UI
bugraoz93
requested changes
Apr 3, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
My review mainly excluding UI. For this specific content, I beleive we shouldn't need to translate
| "taskCount_other": "{{count}} Görev", | ||
| "taskGroup": "Görev Grubu" | ||
| "taskGroup": "Görev Grubu", | ||
| "triggerDagRun": "TriggerDagRunOperator" |
Contributor
There was a problem hiding this comment.
I am not sure we would need entry for unique Operator name. I don’t think so if they are all the same since no need to go into detail of translating each operator
Member
|
Could you share a screenshot of this part? It would help me better understand it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new TriggerNode component for rendering trigger nodes in the DAG graph view with proper internationalization support.
Changes
TriggerNode.tsxcomponent for rendering trigger nodes in the graphTriggerNodeingraphTypes.tsnodeTypesgraph.triggerDagRuntranslation key to all 21 locale filessensornode type registration for completenessThe TriggerNode component displays trigger nodes with:
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.5 (OpenCode Agent) following the guidelines