Refactor E2E page objects with toPass resilience and simplify specs#64666
Open
choo121600 wants to merge 1 commit intoapache:mainfrom
Open
Refactor E2E page objects with toPass resilience and simplify specs#64666choo121600 wants to merge 1 commit intoapache:mainfrom
choo121600 wants to merge 1 commit intoapache:mainfrom
Conversation
choo121600
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
choo121600
force-pushed
the
e2e/03-page-objects-simple-specs
branch
from
2b5655e to
8fe90da
Compare
choo121600
changed the title
choo121600
force-pushed
the
e2e/03-page-objects-simple-specs
branch
from
8fe90da to
7e0063b
Compare
Member
Author
|
I'll leave this as a draft until the E2E CI is enabled. |
choo121600
force-pushed
the
e2e/03-page-objects-simple-specs
branch
2 times, most recently
from
65b8da3 to
8c9589f
Compare
choo121600
force-pushed
the
e2e/03-page-objects-simple-specs
branch
from
8c9589f to
d23cc81
Compare
bbovenzi
reviewed
Apr 14, 2026
| await expect(async () => { | ||
| await this.navigateTo("/assets"); | ||
| await this.page.waitForURL(/.*assets/, { timeout: 10_000 }); | ||
| }).toPass({ intervals: [2000], timeout: 60_000 }); |
Contributor
There was a problem hiding this comment.
Do we really need a fully minute?
| */ | ||
| import { expect } from "@playwright/test"; | ||
| import type { Page, Locator } from "@playwright/test"; | ||
| import { waitForServerReady } from "tests/e2e/utils/health"; |
Contributor
There was a problem hiding this comment.
So we don't need this anymore cause we instead waitUntil: "domcontentloaded". Is that right?
If so, can we just delete waitForServerReady entirely since we're no longer calling it anywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Refactor all page objects to adopt Playwright's
toPasspattern for navigation and hydration checks, replacing fragilewaitForSelector/waitForTimeoutusageEncapsulate UI interactions (filter menus, form fills, table waits) into page object methods, removing direct
pageaccess from specsrelated: #64024
Was generative AI tooling used to co-author this PR?
claude
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.