Load hook metadata from YAML without importing Hook class#63826
Merged
potiuk merged 10 commits intoapache:mainfrom Apr 4, 2026
Merged
Load hook metadata from YAML without importing Hook class#63826potiuk merged 10 commits intoapache:mainfrom
potiuk merged 10 commits intoapache:mainfrom
Conversation
yuseok89
force-pushed
the
hook-meta-load-from-yaml
branch
from
9ef77fa to
7cbaccd
Compare
1 task
yuseok89
requested review from
Fokko,
RNHTTR,
bugraoz93,
choo121600,
dabla,
ephraimbuddy,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
josh-fell,
jscheffl,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
rawwar,
shahar1 and
shubhamraj-git
as code owners
2 tasks
amoghrajesh
reviewed
Mar 31, 2026
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Direction looks fine, some comments but otherwise looks fine!
airflow-core/src/airflow/api_fastapi/core_api/services/ui/connections.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/ui/connections.py
Outdated
Show resolved
Hide resolved
Member
|
@yuseok89 This PR has a few issues that need to be addressed before it can be reviewed — please see our Pull Request quality criteria. Issues found:
What to do next:
There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
choo121600
reviewed
Apr 3, 2026
Member
choo121600
left a comment
choo121600
left a comment
There was a problem hiding this comment.
Looks great!
This part was causing flaky issues, so thanks for fixing it 🙌
potiuk
approved these changes
Apr 4, 2026
potiuk
added
the
backport-to-v3-2-test
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2026
…#63826) * Load hook metadata from YAML without importing Hook class * Add hook-name to all provider.yaml connection-types * Add hook-name to connection types and regenerate get_provider_info.py * Fix ruff import order in connections.py * fix: import ProvidersManager at top level per review * Fix provider connection hook display names * Add iter_connection_type_hook_ui_metadata for connection UI hook metadata (cherry picked from commit c4a209b) Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 4, 2026
…apache#63826) * Load hook metadata from YAML without importing Hook class * Add hook-name to all provider.yaml connection-types * Add hook-name to connection types and regenerate get_provider_info.py * Fix ruff import order in connections.py * fix: import ProvidersManager at top level per review * Fix provider connection hook display names * Add iter_connection_type_hook_ui_metadata for connection UI hook metadata (cherry picked from commit c4a209b) Co-authored-by: Yuseok Jo <yuseok89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #61815
Loading the Connection Add page is slow on the first uncached request because
hook_meta_data()imports Hook classes for every connection type. With 129+ providers, this cost becomes significant before the response can be cached.This PR changes the
GET /ui/connections/hook_metaresponse so it no longer imports Hook classes and instead uses only the metadata from provider.yaml via_load_ui_metadata(). This was made possible by @amoghrajesh 's provider.yaml migration, which moved connection UI metadata into YAML.In this change,
hook-nameis added to connection-types in provider.yaml for display in the connection type dropdown (falls back toconnection_typewhen absent).Before
Screen.Recording.2026-02-12.at.9.34.40.PM.mov
After
Screen.Recording.2026-03-18.at.11.04.44.PM.mov
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.