Skip to content

dc/577 delete by url#583

Merged
gjwgit merged 4 commits intodc/573_metadata_web_appfrom
dc/577_delete_by_url
Feb 4, 2026
Merged

dc/577 delete by url#583
gjwgit merged 4 commits intodc/573_metadata_web_appfrom
dc/577_delete_by_url

Conversation

@cdawei
Copy link
Collaborator

@cdawei cdawei commented Feb 4, 2026

Pull Request Details

What issue does this PR address

  • Use named parameter fileUrl in deleteFile() instead of a relative path.

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@cdawei cdawei changed the base branch from dev to dc/573_metadata_web_app February 4, 2026 23:02
@cdawei cdawei mentioned this pull request Feb 4, 2026
28 tasks
@gjwgit gjwgit merged commit 2c2e59c into dc/573_metadata_web_app Feb 4, 2026
19 of 20 checks passed
@gjwgit gjwgit deleted the dc/577_delete_by_url branch February 4, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants