chore(packaging): Migrate from setuptools to hatchling
#733
Conversation
This is another modern build backend. The patch deletes `setup.py` from the repository, and adds configuration for `hatchling` and declares PEP 621 metadata in `pyproject.toml`. It does not attempt to change the previously existing behavior.
webknjaz
changed the title
setuptools to hatchlingsetuptools to hatchling
webknjaz
changed the title
setuptools to hatchlingsetuptools to hatchling
| [[project.authors]] | ||
| name = 'Contributors' # FIXME | ||
| # email = 'степан@криївка.укр' |
There was a problem hiding this comment.
Ну не Гіга і на тому спасибі :D
There was a problem hiding this comment.
Та тут просто взагалі трохи дивне значення в оригіналі. Потім треба нормально заповнити authors/maintainers. Але я не хотів цим займатися зараз, лише дуже мінімальна міграція.
There was a problem hiding this comment.
Let's stick with ASCII please since it's not all of the pre-commit-terraform users who can read non-English.
There was a problem hiding this comment.
It's just a code comment. Someone should change it to real values.
There was a problem hiding this comment.
It's just a code comment that is unreadable by English-only users. Most of the time it's just a garbage symbols for them, you know.
There was a problem hiding this comment.
Someone should change it to real values.
Until then, it's best to replace with ASCII chars or remove. It's just an opinion of mine though. I'll deffer this to @MaxymVlasov as main collaborator.
MaxymVlasov
changed the title
setuptools to hatchlingsetuptools to hatchling
|
@webknjaz @MaxymVlasov Would it make sense 1) to add a brief outline to this PR description of what is changing for end users (if any), what benefits this change adds to |
This actually affects only how hooks written on python discovered by other python tools (in our case pre-commit itself) Currently there only 1 python hook - terraform_docs_replace, deprecated for years. |
|
We talked about it privately so some context might be missing. But essentially nothing changes for anyone really. |
|
@webknjaz @MaxymVlasov Thanks for details and context. Let's anyways add details in PRs description so that other contributors have an idea on the context of private discussions 🤝 |
|
About benefits @webknjaz can provide better info, but AFAIK, setup.py in this repo actually configured in wrong way from day 1 And this PR with bunch of others, make python hooks more isolated and predictable during direct calls to hooks via test execution, for instance. And just get rid of of legacy stuff which just don't work |
Yep-yep, already got the idea =) My point is to share context within PR description when PR is created =) |
|
@yermulnik I'll try adding more context in general. It's just that Max asked for help, which lead to me discovering a number of typical structural and infra problems in the repo. So I wanted to make a few small PRs to address that but I don't have a lot of time to dedicate to this. |
Appreciate it 🤝
Didn't want to add burden for you. Just am carrying about future reference and posterity. |
|
This PR is included in version 1.97.0 🎉 |
4 participants
This is another modern build backend. The patch deletes
setup.pyfrom the repository, and adds configuration forhatchlingand declares PEP 621 metadata inpyproject.toml.It does not attempt to change the previously existing behavior.
Put an
xinto the box if that apply:Description of your changes
$sbj.
How can we test changes
python -Im build