fix: preserve thinking=disabled as --thinking-disabled flag#699
Open
shubham108prakash-hub wants to merge 1 commit intoanthropics:mainfrom
Open
fix: preserve thinking=disabled as --thinking-disabled flag#699shubham108prakash-hub wants to merge 1 commit intoanthropics:mainfrom
shubham108prakash-hub wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #693
Problem
When
thinking={"type": "disabled"}was set inClaudeAgentOptions,the SDK was converting it to
--max-thinking-tokens 0.This loses the user's explicit intent because:
--max-thinking-tokens 0= ambiguous, may be ignoredthinking={"type": "disabled"}= explicit opt-outAnthropic-compatible third-party providers treat these differently,
causing thinking to remain enabled even when the user explicitly disabled it.
Fix
Changed the
disabledcase in_build_command()to append--thinking-disabledflag instead of setting tokens to 0.Before:
elif t["type"] == "disabled":
resolved_max_thinking_tokens = 0
After:
elif t["type"] == "disabled":
cmd.append("--thinking-disabled")
Testing
test_build_command_with_thinking_disabledintests/test_transport.py--thinking-disabledis present in command--max-thinking-tokensis NOT present when disabled