fix(tui): Center the initially selected session in the session_list (resolves #8558) #8560
+22
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'center' parameter to moveTo() function for viewport centering - Use setTimeout to defer scroll until component is rendered - Pass center=true from filter/current effect for initial positioning - Keyboard navigation retains edge-scroll behavior for smooth UX This fixes an issue where the selected item could be outside the visible viewport when opening dialogs like the session list.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
If desired, I do also have another branch in my pocket that automatically recenters the viewport as the selection is moved using the keyboard in all of the modal selection list windows that use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR attempts to ensure that the initially selected session when the
session_listis opened is always within the viewport when opening the session list by trying to center it within the viewport.Resolves #8558
Before (after following the procedure described in the issue)
After
How did you verify your code works?
A/B testing and running all tests in the project to ensure that no failures were introduced.