fix: make home/end keys work in menu list modal windows (resolves #7190) #8347
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
ariane-emory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves UX when navigating all of the various menu/list modal windows by making the
home/endkeys scroll to the top/bottom of the list. This improves adherence to the principle of least surprise: users are likely to press these keys, expecting them to work, since they do in most other applications, and currently they will be surprised to discover that they do not work. This change eliminates that stumbling block and provides a smoother navigation experience in the menu list modal windows.Since they all use shared code, this fix applies to all the menu list modal windows:
session_timeline,command_list,model_list, and possibly also others that I'm not aware of or that have slipped my mind at the present moment.How did you verify your code works?
I have been using it for weeks in my personal fork and I've never had a problem with it. C'mon, it's two very simple lines, what could go wrong?
Resolves #7190
Resolves #8344