docs: fix permission system documentation in agents section #7652
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
IdrisGit
force-pushed
the
update-agents-permission-section
branch
from
d0fd373 to
0239fd0
Compare
| ``` | ||
|
|
||
| :::tip | ||
| Use pattern matching for commands with arguments. `"grep *"` allows `grep pattern file.txt`, while `"grep"` alone would block it. Commands like `git status` work for default behavior but require explicit permission (like `"git status*"`) when arguments are passed. |
Collaborator
There was a problem hiding this comment.
i think u can use git status * instead of git status*
Contributor
Author
There was a problem hiding this comment.
removed this one instead of the one in permissions.mdx, as I think it makes more sense there than in agents.mdx.
| Only analyze code and suggest changes. | ||
| ``` | ||
|
|
||
| :::tip |
Contributor
Author
There was a problem hiding this comment.
kept this one and removed the duplicate one in agents.mdx
removed it from agents.mdx, as I think it makes more sense in the permissions page rather than in agents documentation page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the agents section in the permissions documentation to reflect the new granular rules system. The previous examples showed mismatched patterns (e.g.,
"git status"without wildcards) that didn't properly demonstrate how pattern matching works for commands with arguments. The fix adds"grep *"examples to clearly demonstrate when pattern matching is essential, updates the explanatory tip to show both scenarios (commands that work without arguments vs. commands that require pattern matching).How did you verify your code works?
Ran the docs development server locally to verify the changes render correctly and the examples are properly formatted. The documentation now accurately reflects how the granular permission system works with clear examples showing when to use pattern matching for commands that accept arguments like
grep, versus commands that work with basic usage likegit status.