fix: warn on unrecognized permission keys in opencode.json#15601
Open
Br1an67 wants to merge 1 commit intoanomalyco:devfrom
Open
fix: warn on unrecognized permission keys in opencode.json#15601Br1an67 wants to merge 1 commit intoanomalyco:devfrom
Br1an67 wants to merge 1 commit intoanomalyco:devfrom
Conversation
The permission block used .catchall(PermissionRule) which silently accepted unknown keys. Users migrating from Claude Code (PascalCase keys like "Bash") got no signal that their permissions had no effect. Now logs a warning for each unrecognized key, with a suggestion if the lowercase version is a known key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15507
Type of change
What does this PR do?
The
permissionblock inopencode.jsonuses.catchall(PermissionRule)which silently accepts unknown keys. Users migrating from Claude Code (which uses PascalCase like"Bash","Read") get zero signal that their permissions have no effect.The fix adds a
KNOWN_PERMISSION_KEYSset and checks each key in thepermissionTransformfunction. Unrecognized keys trigger a warning log with a case-insensitive hint (e.g."Bash" — did you mean "bash"?).The
.catchall()is preserved so the schema doesn't reject configs outright — the warning is informational.How did you verify your code works?
Ran the existing config test suite (
bun test test/config/config.test.ts) — all previously-passing tests still pass (55/61, 6 pre-existing failures unrelated to permissions).Screenshots / recordings
N/A — log output change, no UI impact.
Checklist