fix: make server.close() return a Promise#15597
Open
Br1an67 wants to merge 1 commit intoanomalyco:devfrom
Open
fix: make server.close() return a Promise#15597Br1an67 wants to merge 1 commit intoanomalyco:devfrom
Br1an67 wants to merge 1 commit intoanomalyco:devfrom
Conversation
server.close() now returns a Promise that resolves when the child process has exited, enabling graceful shutdown and preventing port conflicts when restarting quickly (e.g. tsx --watch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #3841
Type of change
What does this PR do?
server.close()returned bycreateOpencodeServer()previously terminated the child process synchronously and returnedundefined. This made graceful shutdown impossible — scripts usingtsx --watchor similar hot-reload tools would try to start a new server before the previous one released its port.The fix wraps the process termination in a Promise that resolves on the
exitevent, so callers canawait server.close()to wait for the port to be released. Also handles the edge case where the process has already exited.Applied to both
packages/sdk/js/src/server.tsandpackages/sdk/js/src/v2/server.ts.How did you verify your code works?
Reviewed the Node.js child_process API — the terminate method sends SIGTERM and the exit event fires once the process terminates. The Promise correctly resolves in both normal and already-exited cases.
Screenshots / recordings
N/A — SDK change, no UI impact.
Checklist