Skip to content

Conversation

@ariane-emory
Copy link
Contributor

@ariane-emory ariane-emory commented Jan 25, 2026

What does this PR do?

Improves adherence to the Principle of Least Surprise (as well as consistency with other similar menu commands in OpenCode) by moving the code for the "Disable / Enable Animations" menu item in the command_list such that it will be visible at all times instead of only once a session has been started.

  • Remove animations toggle command from Session component
  • Add animations toggle command to global System category in App component
  • Makes animation toggle available immediately when OpenCode starts
  • Uses consistent kv.get/kv.set pattern for animations_enabled flag

How did you verify your code works?

Manual A/B testing.

After

Screenshot 2026-01-25 at 12 31 26 AM

Before

Screenshot 2026-01-25 at 12 31 38 AM

Resolves #10495.

- Remove animations toggle command from Session component
- Add animations toggle command to global System category in App component
- Makes animation toggle available immediately when OpenCode starts
- Uses consistent kv.get/kv.set pattern for animations_enabled flag
@github-actions
Copy link
Contributor

Hey! Your PR title Move animations toggle to global System category (resolves #10495) doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@ariane-emory ariane-emory marked this pull request as ready for review January 25, 2026 05:50
@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@ariane-emory ariane-emory changed the title Move animations toggle to global System category (resolves #10495) fix: Move animations toggle to global System category (resolves #10495) Jan 25, 2026
@ariane-emory ariane-emory changed the title fix: Move animations toggle to global System category (resolves #10495) fix(tui): Move animations toggle to global System category (resolves #10495) Jan 25, 2026
@rekram1-node rekram1-node merged commit 3071720 into anomalyco:dev Jan 25, 2026
9 checks passed
@ariane-emory ariane-emory deleted the fix/pols-adherence branch January 25, 2026 23:12
ariane-emory added a commit to ariane-emory/opencode that referenced this pull request Jan 26, 2026
- Move diff wrapping toggle from session-level to global app-level commands
- Replace local diffWrapMode signal with kv.signal('diff_wrap_mode', 'word')
- Follow pattern from issue anomalyco#10497 fix for animations toggle
- Toggle now accessible before sending first message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI:"Disable/Enable animations" ought be available in the command_list prior to session beginning

2 participants