fix(pty): Add UTF-8 defaults for Windows PTY #10489
Closed
+76
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace placeholder path with real typings so typecheck passes on Windows.
Replace placeholder path with real typings so typecheck passes on Windows.
Add platform-specific UTF-8 environment variables and shell startup args for better CJK character support on Windows. - Set LANG and LC_ALL to en_US.UTF-8 - Set PYTHONUTF8 and PYTHONIOENCODING for Python scripts - Add chcp 65001 for CMD.exe - Configure PowerShell UTF-8 encoding
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Potential Related PRPR #10381: "fix: specify UTF-8 encoding for Buffer.toString() on Windows - Issue #10341" Why it's related: This PR also addresses UTF-8 encoding issues on Windows. While PR #10489 focuses on PTY and environment variables for CJK character display, PR #10381 appears to address UTF-8 encoding at the Buffer level. Both are tackling Windows encoding problems and may have overlapping solutions or could benefit from coordination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix CJK (Chinese, Japanese, Korean) character display issues in Windows terminals by adding proper UTF-8 encoding defaults.
Problem
Windows terminals don't have UTF-8 encoding enabled by default, causing CJK characters to display as gibberish or question marks. This affects:
Solution
This PR adds platform-specific UTF-8 defaults for Windows:
Environment Variables
LANG=en_US.UTF-8- Sets locale for Unix-style toolsLC_ALL=en_US.UTF-8- Overrides all locale categoriesPYTHONUTF8=1- Enables UTF-8 mode for Python 3.7+PYTHONIOENCODING=utf-8- Sets Python stdin/stdout/stderr encodingShell Startup Arguments
chcp 65001to set code page to UTF-8Testing
Tested on Windows with:
Impact
Related Issues
This PR addresses the root cause of several Windows encoding issues:
Closes #10491