Conversation
Do *not* include the `DllMain` entry point in the static build, only when it's a shared build.
|
@ebassi Maybe you want to look at this PR? |
|
I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on. |
|
It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress. |
I understand, no blame.
I agree. I guess, we can extend the github action workflow file with a static build: |
|
Ping? (sorry to just bother you, otherwise I don't see this getting merged) |
|
Any feedback? |
|
I would appreciate if this is supported upstream as well. |
|
Is it really enough to not compile DllMain? Wouldn't it take an alternative way to do the initialization which is in the body of this function? |
|
Having tested a few of these branches, #304 is the one that seems to work the best for static library builds. |
Do not include the
DllMainentry point in the static build, only when it's a shared build.