Map #3
Open
Map #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vh02
reviewed
May 19, 2019
|
|
||
|
|
||
| }, | ||
| () => { |
Contributor
There was a problem hiding this comment.
Error handling? (err, data) => { if (!err) {this.setState({ loading: false})} }
vh02
reviewed
May 19, 2019
src/components/Map.jsx
Outdated
| markers={this.state.markers} | ||
| userLocation={this.state.userLocation} | ||
| confirmCheckpoint={this.confirmCheckpoint.bind(this)} | ||
| handleMarkerClick={this.handleMarkerClick.bind(this)} |
Contributor
There was a problem hiding this comment.
re: handleMarkerClick issue, since decorating doesn't work, could consider getting mouse position and comparing to an array of all the rendered marker positions.
vh02
reviewed
May 19, 2019
| let toRad = (val) => { | ||
| /** Converts numeric degrees to radians */ | ||
| return val * Math.PI / 180; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.