Add adaptive track format comparator with safe fallback#3068
Open
AndyWangLYN wants to merge 1 commit intoandroidx:releasefrom
Open
Add adaptive track format comparator with safe fallback#3068AndyWangLYN wants to merge 1 commit intoandroidx:releasefrom
AndyWangLYN wants to merge 1 commit intoandroidx:releasefrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
df1bdf0 to
d29702f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional custom format ordering for AdaptiveTrackSelection so apps can influence ABR priority beyond bitrate-only ordering.
This PR is refined version of the PR: #3064 in which I received comments about track format sorting. Intend to close above PR if this one is deemed good eventually.
What changed
Added AdaptiveTrackSelection.Factory#setTrackFormatComparator(Comparator).
Plumbed comparator through adaptive selection construction.
Added protected constructor support so AdaptiveTrackSelection subclasses can pass a comparator.
Kept existing default ordering (bitrate descending) when no comparator is provided.
Added safety fallback: if comparator sorting throws any error, ordering falls back to default bitrate-desc behavior.
Updated track selection docs to clarify that order is “selection order” (default remains bitrate-desc).
Why
Current adaptive selection effectively prioritizes higher bitrate first. This makes it hard to prioritize developer-defined rules (for example, quality score ranking). These hooks allow custom ordering without changing core ABR switching logic.
Testing Done