-
Notifications
You must be signed in to change notification settings - Fork 129
Trivialkart unreal #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivialkart unreal #107
Conversation
Initial Unreal Project with Git Ignore and Attributes for LFS
Added Empty Map, Trivial Kart 2D assets, converter 2D assets into UI Textures, Paper 2D Textures, extracted Sprites and added Flip book animation for Cars and Flag
Added PGS Authentication with login, status check and nickname function in the Game Instance.
Added IAP and Achievements along with basic HUD Implementation
Added PlayBoard widget with button interactions and Widget Removal function in HUD
Added Kart Movement with Player States and Player Controller
Added three achievements example
Summary of ChangesHello @RKS13D, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Unreal Engine project, 'TrivialKart_Unreal', designed to showcase the integration of Google Play Services. It lays the groundwork for a kart racing game, complete with core gameplay mechanics like movement, fuel management, and distance tracking, alongside a comprehensive user interface for interacting with game features and the Google Play ecosystem. The changes encompass project configuration, C++ gameplay logic, and UI elements, all aimed at demonstrating a functional mobile game with modern platform service integration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the 'Trivialkart' Unreal Engine sample project, demonstrating integration with Google Play services for features like authentication, achievements, and in-app purchases. The changes are extensive, covering project setup, configuration, C++ game logic, and UI widgets. My review has identified a critical security vulnerability due to a hardcoded password in a configuration file, which must be addressed immediately. Additionally, there are several high-severity bugs in the game logic, particularly concerning frame-rate dependent calculations and incorrect API usage that could lead to unexpected behavior. I have also noted several medium-severity issues related to code maintainability, configuration redundancy, and potential memory leaks. The provided feedback and code suggestions aim to resolve these issues and improve the overall quality and security of the project.
...ivialkart_unreal/Source/TrivialKart_Unreal/Private/GameInstances/TrivialKartGameInstance.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Infos/TrivialKartPlayerState.h
Show resolved
Hide resolved
...alkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Infos/TrivialKartPlayerState.cpp
Outdated
Show resolved
Hide resolved
...ivialkart_unreal/Source/TrivialKart_Unreal/Private/GameInstances/TrivialKartGameInstance.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/GarageWidget.cpp
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PGSWidget.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PlayBoardWidget.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Actors/TrivialKartHUD.h
Show resolved
Hide resolved
…te/Infos/TrivialKartPlayerState.cpp Replaced Name and ID Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…te/GameInstances/TrivialKartGameInstance.cpp Added Log property Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…te/Widgets/PGSWidget.cpp Added float precision Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…te/Widgets/PlayBoardWidget.cpp Rounding up Distance values Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…te/Actors/TrivialKartHUD.cpp Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…te/Actors/TrivialKartHUD.cpp Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…te/GameInstances/TrivialKartGameInstance.cpp Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Actors/KartPawn.cpp
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Actors/TrivialKartHUD.cpp
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Actors/TrivialKartHUD.cpp
Show resolved
Hide resolved
...alkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Infos/TrivialKartPlayerState.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/GarageWidget.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PGSLayoutText.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PGSWidget.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PlayBoardWidget.cpp
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/StoreWidget.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Actors/TrivialKartHUD.h
Show resolved
Hide resolved
borisf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please add copyright to the files, I think this how to do in Unreal ==> // Fill out your copyright notice in the Description page of Project Settings.
If some of the C++ files are autogenerated during build, not sure we need to add them to source control
...rivialkart_unreal/Source/TrivialKart_Unreal/Public/Controllers/TrivialKartPlayerController.h
Outdated
Show resolved
Hide resolved
.../trivialkart_unreal/Source/TrivialKart_Unreal/Public/GameInstances/TrivialKartGameInstance.h
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Infos/TrivialKartPlayerState.h
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Widgets/GarageWidget.h
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/TrivialKart_Unreal.Build.cs
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Widgets/PGSLayoutText.h
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Widgets/PGSWidget.h
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Widgets/SelectableItem.h
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Widgets/PlayBoardWidget.h
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Public/Widgets/StoreWidget.h
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PlayBoardWidget.cpp
Outdated
Show resolved
Hide resolved
trivialkart/trivialkart_unreal/Source/TrivialKart_Unreal/Private/Widgets/PGSWidget.cpp
Outdated
Show resolved
Hide resolved
...ivialkart_unreal/Source/TrivialKart_Unreal/Private/GameInstances/TrivialKartGameInstance.cpp
Outdated
Show resolved
Hide resolved
|
LGTM. I added minor comments for adding tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Copy right notices added
- Addressed couple of my questions on code patterns and C# usage
borisf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
borisf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
borisf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
borisf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
borisf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The (trivialkart/trivialkart-unreal) directory contains sample demonstrating how to use Online Subsystem Google Play for implementing features like
Google Play Games Authentication
Google Play Games Achievements
Google Play Billing for in-app purchases using Google IAP