Sync changes from internal dev branch.

[lip-liu]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @lip-liu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of WiFi connection handling by integrating a retry mechanism into the connect_to_wifi utility function. This change ensures that transient network issues do not immediately lead to connection failures, instead allowing for multiple attempts with a configurable delay, thereby increasing the overall reliability of network operations.

Highlights

• WiFi Connection Retry Logic: Introduced a retry mechanism for WiFi connection attempts within the connect_to_wifi function to enhance reliability.
• Configurable Retry Parameters: Added new constants, _WIFI_CONNECT_INTERVAL_SEC and _WIFI_CONNECT_RETRY_TIMES, to allow configuration of the delay between retries and the maximum number of attempts.
• Error Handling for WiFi Connections: Implemented try-except blocks to catch errors.ApiError during WiFi connection attempts, logging warnings for failures and re-raising the error only after all retries are exhausted.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a retry mechanism to the connect_to_wifi function in betocq/setup_utils.py. This is a valuable improvement for test stability, as Wi-Fi connections can be unreliable. The implementation is sound, using a configurable number of retries and appropriate delays. My feedback includes a suggestion to improve the clarity of a log message to aid in debugging.

[gemini-code-assist]

The log message "retry attempt" can be a bit ambiguous. When i is 0, it's the first attempt, not a retry. Using "attempt" would be clearer. Also, including the total number of attempts can provide more context in the logs.

Suggested change

	ad.log.warning(
	f'Failed to connect to wifi {ssid}, retry attempt {i + 1}'
	)
	ad.log.warning(
	f'Failed to connect to wifi {ssid}, attempt {i + 1}/{num_retries}.'
	)