-
Notifications
You must be signed in to change notification settings - Fork 15
Update library versions and switch to using built-in Kotlin #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of the project's build environment and dependencies. The primary goal is to align the application with the latest Android SDK (API 36) and leverage newer versions of various libraries and tools, including Gradle, Android Gradle Plugin, Kotlin, and several AndroidX components. These updates ensure compatibility, incorporate the latest features, and potentially improve performance and stability. Additionally, minor build configuration adjustments and a refactoring in a spatial navigation component are included. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily updates various dependencies, Android SDK versions, and Gradle versions across the project. It also includes an update to the XR Compose API usage, changing ApplicationSubspace to Subspace. These changes are generally good for keeping the project up-to-date with the latest libraries and platform features.
* main: 🤖 Updates screenshots ci: Grant write permissions to GITHUB_TOKEN CI: bad path Addresses review comments ci: Add screenshot testing to workflow Make category gradients deterministic and add new goldens ci: Update build workflow to run unit tests Add JaCoCo test coverage and Robolectric tests Adds feature tests and set up robolectric. Adds feature tests Add feature-tests documentation Adds component tests Docs update unit tests Gemini 3 flash docs # Conflicts: # AdaptiveJetStream/gradle.properties # AdaptiveJetStream/gradle/libs.versions.toml
What have I done and why
I have updated all the library and plugin dependencies in this project to use the latest stable versions. The only exception to this is the
androidx.benchmark:benchmark-baseline-profile-gradle-pluginwhich I have updated to the latest alpha build because it fixes a compatibility issue with the new DSL introduced in Gradle 9.0.I am doing this as a prerequisite step before refactoring, adding tests and migrating to Navigation 3.
Notably, I had to migrate the XR function
ApplicationSubspacetoSubspace. There's no documentation on this so I would appreciate it if someone from the XR team (@fuentespatrick maybe?) could confirm that this is correct.