Skip to content

Conversation

@bjuppa
Copy link

@bjuppa bjuppa commented Apr 1, 2021

This PR is replacing the dependency on deprecated fzaninotto/faker with the community maintained fakerphp/faker package.

See #2 for more details!

I haven't gotten the tests to run locally because of PHP versions, so I'm creating this PR in an attempt to trigger Travis builds.
I'm expecting to edit the Travis config along the way if tests doesn't pass.

@bjuppa
Copy link
Author

bjuppa commented Apr 1, 2021

Oh, I see Travis was not connected to automatically run on PRs.

Then I'd like to give more information how I've tested this change using my own project https://github.com/bjuppa/laravel-blog

In the composer.json you can see a temporary reference to the branch this PR will merge:
https://github.com/bjuppa/laravel-blog/blob/f6a102d63efb673d412ff59bc2060d5262fbdfb3/composer.json#L32-L40

So, the changes in this PR at least works with this Travis setup in my package, covering PHP 7.3, 7.4 and 8.0: https://github.com/bjuppa/laravel-blog/blob/master/.travis.yml

@vstyler96
Copy link

@andrefigueira are this changes acceptable to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants