Skip to content

[BUGFIX] Try composer autoload of tool installation folder first#268

Merged
simonschaufi merged 1 commit intoandreaswolf:mainfrom
liayn:autoloading-fix
Mar 27, 2025
Merged

[BUGFIX] Try composer autoload of tool installation folder first#268
simonschaufi merged 1 commit intoandreaswolf:mainfrom
liayn:autoloading-fix

Conversation

@liayn
Copy link
Contributor

@liayn liayn commented Mar 26, 2025

"fractor" as a tool may/should not be installed as a project dependency, but live separately.
Hence, the authoritative composer autoload is the
one where the tool has been installed to.

For legacy reasons the project's autoload information is kept as a fallback.

Resolves: #264

@simonschaufi
Copy link
Collaborator

Thank you for your contribution. I'll look into the code style issue and then merge it.

@liayn
Copy link
Contributor Author

liayn commented Mar 27, 2025

Thank you for your contribution. I'll look into the code style issue and then merge it.

Seems like a phpcs update is the reason

"fractor" as a tool may/should not be installed as a
project dependency, but live separately.
Hence, the authoritative composer autoload is the
one where the tool has been installed to.

For legacy reasons the project's autoload information
is kept as a fallback.

Resolves: andreaswolf#264
@simonschaufi simonschaufi merged commit 76c6bc7 into andreaswolf:main Mar 27, 2025
14 checks passed
@liayn liayn deleted the autoloading-fix branch March 28, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect composer autoload file used

2 participants