[FEATURE] Add traverseStatementsWithCallable #243
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonschaufi
force-pushed
the
traverseStatementsWithCallable
branch
from
a454da1 to
ffec951
Compare
Owner
|
@simonschaufi What is the reasoning behind this change? I cannot see any place where this is used within this PR, so I assume you need it for something else. Since this changes the behaviour of our base interface (leaveNode may now return a statement or drop a statement), I think we should discuss this a bit before merging. And probably add this globally for all Fractor implementations if we agree this is a good thing. |
Collaborator
Author
|
This is a copy from Rector (with adjustments to Fractor). I might actually need this in #241 , not sure yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.