-
Notifications
You must be signed in to change notification settings - Fork 9
feat: router re-write #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potentially the most heinous thing I have ever written
includes pretty major change to `QubitHandler` to differentiate router `Ctx` from handler `Ctx`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete overhaul of the router, and the
handlermacro. Instead of thehandlermacro replacing the function definition with a customstructwhich implements a trait in order to 'smuggle' reflection information (function and parameter names) to the runtime, this implementation leaves the function definition as-is and useslinkmeto save the information during the linking step. This provides a number of advantages:Another significant change is that the macro no longer tries to statically analyse the handler signature (such as checking if the return type is
impl ____to guess if it's a stream). Now, the trait system is used to correctly infer the return type every time! Along with being more predictable, this allows for other non-stream traits to be returned from handlers, such asimpl Iterator!