Skip to content

Conversation

@nunojsa
Copy link
Collaborator

@nunojsa nunojsa commented Aug 4, 2025

PR Description

Use the proper macros to define a PM struct in conjucntion with using pm_ptr(). Otherwise, we get compiler complains if PM is not enabled.

Fixes: fecd9b7 ("iio: adc: ad4630: make use of pm_ptr()")

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa added 2 commits August 4, 2025 13:41
AD4630 needs to select SPI_OFFLOAD otherwise it will fail to build in
case it's not enabled.

Fixes: cd8e37d ("iio: adc: ad4630 migrate to new offload implementation")
Signed-off-by: Nuno Sá <[email protected]>
Use the proper macros to define a PM struct in conjucntion with using
pm_ptr(). Otherwise, we get compiler complains if PM is not enabled.

Fixes: fecd9b7 ("iio: adc: ad4630: make use of pm_ptr()")
Signed-off-by: Nuno Sá <[email protected]>
@nunojsa
Copy link
Collaborator Author

nunojsa commented Aug 4, 2025

v2:

  • New patch to fix when SPI_OFFLOAD is not enabled.

Copy link
Contributor

@machschmitt machschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunojsa nunojsa merged commit 7433b2d into main Aug 5, 2025
18 of 19 checks passed
@nunojsa nunojsa deleted the staging/ad4630-fix branch August 5, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants