Fork ResizeObserver polyfill to support shadow DOM and FIE #31850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
nit: rename from |
samouri
reviewed
Jan 8, 2021
dvoytenko
changed the title
Contributor
Author
done |
samouri
approved these changes
Jan 8, 2021
Member
samouri
left a comment
samouri
left a comment
There was a problem hiding this comment.
Do you think we'd potentially be better served by promoting this to its own repo? E.g. ampproject/resize-observer-polyfill
Contributor
Author
We will do it if we do not get the response. But I think the rule of thumb for now is to give a few weeks before forking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #31540.
See que-etc/resize-observer-polyfill#79 for more details.