devise/override: add active_for_authentication? #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in commit heartcombo/devise@edee511 devise renamed active? to active_for_authentication? we override that method to prevent suspended accounts from logging in which doesn't work after devise v1.2.0 Signed-off-by: Adam Wolk <[email protected]>
Author
|
Hi, thanks for updating the gem and publishing it to rubygems! I cross checked the published version and it appears that it contains changes that are not present in this repository, perhaps you forgot to push v6.0.1 to github? Regarding the change in the pull request itself, I defaulted to keeping the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in commit
heartcombo/devise@edee511
devise renamed active? to active_for_authentication?
we override that method to prevent suspended accounts
from logging in which doesn't work after devise v1.2.0
Signed-off-by: Adam Wolk [email protected]