-
-
Notifications
You must be signed in to change notification settings - Fork 8
Feature/test docker build #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4ead609 to
f7b8f9e
Compare
CMakeLists.txt
Outdated
| ${ENABLE_SANITIZER_THREAD} | ||
| ${ENABLE_SANITIZER_MEMORY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sanitizers cannot be enabled with each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this is handled by check_sanitizers_support()
see too ENABLE_SANITIZER_LEAK on Darwin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check_sanitizers_support only checks if the compiler supports that variable. Maybe we should handle that as well.
.gitlab-ci.yml
Outdated
| # XXX WHY? set time-zone | ||
| # TZ=Canada/Pacific | ||
| # ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember, this is required for proper downloading of the tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my gitlab pipline
| - cmake --workflow --preset ${CI_compiler}-debug | ||
| - gcovr . | ||
| - cmake --workflow --preset ${CI_compiler}-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usage example of cmake --workflow --preset
c4efb3c to
60b61b5
Compare
aminya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase after #20
70fa53c to
743901c
Compare
d5651f2 to
b2d0d90
Compare
Update .gitlab-ci.yml file
Fix gcovr html report
Update Dockerfile
Update docker related docu and config
Add simple CMakeWorkflowPresets
Try to use $env{CC} to control the compiler variant
Format CMakePresets files
Do not waste time, use run-clang-tidy
Upgrade project_options
Use cmake workflow on gitlab-ci
Update link to setup-cpp-x64-linux
Install current cmake version with pythone3-pip on CI
Cleanup .gitlab-ci.yml file
Use gcovr on gitlab-ci
add build/coverage for CI gcovr
Enable clang-tidy on CI builds
Use custom-collapsible-sections
Cleanup .gitlab-ci.yml
Use CI_compiler variable while build
use target_find_dependencies() again
Use Dockerfile from setu-cpp
As recommended in review
Update docker.md
Update setup-cpp
Upgrade to gcovr
Use newest cmake and project_options
Use gcov-13 with gcc on CI
b2d0d90 to
636a8ef
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
19cd25d to
e407428
Compare
Update docker related docs and config
Update
.gitlab-ci.ymlfile usingcmake workflow presetsandgcovr.