Skip to content

Conversation

@ClausKlein
Copy link
Contributor

@ClausKlein ClausKlein commented Aug 9, 2023

Update docker related docs and config

Update .gitlab-ci.yml file using cmake workflow presets and gcovr.

CMakeLists.txt Outdated
Comment on lines 90 to 95
${ENABLE_SANITIZER_THREAD}
${ENABLE_SANITIZER_MEMORY}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sanitizers cannot be enabled with each other

Copy link
Contributor Author

@ClausKlein ClausKlein Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this is handled by check_sanitizers_support()

see too ENABLE_SANITIZER_LEAK on Darwin

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_sanitizers_support only checks if the compiler supports that variable. Maybe we should handle that as well.

.gitlab-ci.yml Outdated
Comment on lines 16 to 18
# XXX WHY? set time-zone
# TZ=Canada/Pacific
# ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, this is required for proper downloading of the tools

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +49 to +52
- cmake --workflow --preset ${CI_compiler}-debug
- gcovr .
- cmake --workflow --preset ${CI_compiler}-release
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage example of cmake --workflow --preset

@ClausKlein ClausKlein requested a review from aminya September 3, 2023 18:23
@ClausKlein ClausKlein force-pushed the feature/test-docker-build branch 3 times, most recently from c4efb3c to 60b61b5 Compare February 6, 2024 20:17
Copy link
Owner

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase after #20

@ClausKlein ClausKlein force-pushed the feature/test-docker-build branch from 70fa53c to 743901c Compare April 4, 2024 18:56
@ClausKlein ClausKlein force-pushed the feature/test-docker-build branch from d5651f2 to b2d0d90 Compare April 26, 2025 19:04
Update .gitlab-ci.yml file

Fix gcovr html report

Update Dockerfile

Update docker related docu and config

Add simple CMakeWorkflowPresets

Try to use $env{CC} to control the compiler variant

Format CMakePresets files

Do not waste time, use run-clang-tidy

Upgrade project_options

Use cmake workflow on gitlab-ci

Update link to setup-cpp-x64-linux

Install current cmake version with pythone3-pip on CI

Cleanup .gitlab-ci.yml file

Use gcovr on gitlab-ci

add build/coverage for CI gcovr

Enable clang-tidy on CI builds

Use custom-collapsible-sections

Cleanup .gitlab-ci.yml

Use CI_compiler variable while build

use target_find_dependencies() again

Use Dockerfile from setu-cpp

As recommended in review

Update docker.md

Update setup-cpp

Upgrade to gcovr

Use newest cmake and project_options

Use gcov-13 with gcc on CI
@ClausKlein ClausKlein force-pushed the feature/test-docker-build branch from b2d0d90 to 636a8ef Compare April 26, 2025 19:23
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ClausKlein ClausKlein marked this pull request as draft April 27, 2025 08:31
@ClausKlein ClausKlein force-pushed the feature/test-docker-build branch from 19cd25d to e407428 Compare April 27, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants