-
Notifications
You must be signed in to change notification settings - Fork 29
chore: Flutter 3.38.7 with Dart 3.10.7 #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @riscait, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant update to the project's core development environment by upgrading to the latest stable Flutter (3.38.7) and Dart (3.10.7) SDK versions. Alongside this essential update, the PR performs a comprehensive cleanup, removing all remnants of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Flutter to version 3.38.7 and Dart to 3.10.7. It also removes all traces of the freezed and mason packages, which are no longer in use. The changes are mostly correct and align with the PR's goal. I've found a couple of areas for improvement: one related to Dependabot configuration to ensure all relevant dependencies are tracked, and another to improve the accuracy of the documentation regarding code generation tools.
| - [build_runner](https://pub.dev/packages/build_runner) | ||
| - [json_serializable](https://pub.dev/packages/json_serializable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Code Generation" section lists build_runner. While build_runner is used, it's a task runner, not a code generator itself like json_serializable. It would be more accurate and consistent to list the actual code generator packages used in the project. This project uses flutter_gen_runner, go_router_builder, json_serializable, and slang for code generation.
| - [build_runner](https://pub.dev/packages/build_runner) | |
| - [json_serializable](https://pub.dev/packages/json_serializable) | |
| - [flutter_gen_runner](https://pub.dev/packages/flutter_gen_runner) | |
| - [go_router_builder](https://pub.dev/packages/go_router_builder) | |
| - [json_serializable](https://pub.dev/packages/json_serializable) | |
| - [slang](https://pub.dev/packages/slang) |
π What's Done
βοΈ What's Not Done
π Additional Notes
πΌοΈ Image Differences
Pre-launch Checklist
Note
Upgrades the toolchain and cleans up legacy codegen/setup.
3.38.7(.fvmrc, VSCode path) and bump Dart SDK to^3.10.7across workspace and packagepubspec.yamls; updatepubspec.lockSDK constraint*.freezed.dartfrom ignore/filters in.cspell.yaml,codecov.yml,.vscode/settings.json, and formatting scripts; update app README to listbuild_runnerinstead offreezedmason.yamlandmason-lock.jsonWritten by Cursor Bugbot for commit c7ee2aa. This will update automatically on new commits. Configure here.