-
Notifications
You must be signed in to change notification settings - Fork 29
feat: Flutter 3.38.5 and altive_lints 2.1.0 #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @riscait, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on essential dependency and environment updates for the project. It brings the Flutter and Dart SDK versions to their latest stable releases and updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Flutter SDK from 3.38.4 to 3.38.5 (Dart 3.10.4) and upgrades the altive_lints package from 2.0.0 to 2.1.0 across the entire monorepo workspace.
- Updated Flutter/Dart SDK versions in all package pubspec.yaml files
- Updated altive_lints dependency from ^2.0.0 to ^2.1.0 in all packages
- Updated FVM and VS Code configurations to use Flutter 3.38.5
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Updated root melos configuration SDK constraint and altive_lints version |
| packages/widget_catalog/pubspec.yaml | Updated SDK constraint and altive_lints version for widget catalog package |
| packages/util/pubspec.yaml | Updated SDK constraint and altive_lints version for util package |
| packages/themes/pubspec.yaml | Updated SDK constraint and altive_lints version for themes package |
| packages/pub_dev_api_client/pubspec.yaml | Updated SDK constraint and altive_lints version for pub.dev API client |
| packages/flutter_app/pubspec.yaml | Updated SDK constraint and altive_lints version for main app package |
| packages/core/utils/pubspec.yaml | Updated SDK constraint and altive_lints version for core utils |
| packages/core/tracker/pubspec.yaml | Updated SDK constraint and altive_lints version for core tracker |
| packages/core/messenger/pubspec.yaml | Updated SDK constraint and altive_lints version for core messenger |
| packages/core/configurator/pubspec.yaml | Updated SDK constraint and altive_lints version for core configurator |
| packages/core/authenticator/pubspec.yaml | Updated SDK constraint and altive_lints version for core authenticator |
| packages/convenient_widgets/pubspec.yaml | Updated SDK constraint and altive_lints version for convenient widgets |
| .vscode/settings.json | Updated Flutter SDK path to 3.38.5 for VS Code integration |
| .gitattributes | Removed linguist-generated attribute for freezed files |
| .fvmrc | Updated Flutter version manager configuration to 3.38.5 |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Flutter, Dart SDK, and altive_lints across the workspace. The changes are mostly correct and consistent. However, the root pubspec.yaml file seems to have been partially overlooked. While the melos bootstrap configuration is updated, the top-level environment.sdk and dev_dependencies.altive_lints are still pointing to the old versions. For consistency, these should also be updated. I've left a specific comment with details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 2
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
π What's Done
βοΈ What's Not Done
π Additional Notes
πΌοΈ Image Differences
Pre-launch Checklist
Note
Upgrade SDKs and tooling across workspace
Flutterto3.38.5(.fvmrc, VS Code settings) andDartSDK to^3.10.4in allpubspec.yamlsaltive_lints ^2.1.0across packages and Melos bootstrapdependency_overridesforretrofit_generator: 10.2.0(retainanalyzer: 8.2.0,test_api: 0.7.8); refreshpubspec.lock(e.g.,dio 5.9.0).gitattributesto mark only*.g.dartas generatedWritten by Cursor Bugbot for commit 0fd0925. This will update automatically on new commits. Configure here.