build: bump to Flutter 3.38.4 and Dart 3.10 #629
Conversation
Summary of ChangesHello @riscait, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant dependency upgrade and refactoring effort across the project. It updates the core Flutter and Dart SDK versions, migrates data classes from Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant dependency upgrade, bumping Flutter, Dart, and several major packages. It also includes a migration from freezed to equatable for data classes, and refactors routing with the new go_router version. The changes are extensive and mostly well-executed. I've identified a critical compilation error due to an incorrect @override annotation and a medium-severity issue that will likely cause a lint error. Overall, great work on this large-scale update.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 46.15% 47.18% +1.03%
==========================================
Files 27 27
Lines 533 551 +18
==========================================
+ Hits 246 260 +14
- Misses 287 291 +4
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
- remove Freezed and add Equatable instead - bump to altive_lints 2.0.0-dev.3 and remove custom_lint - bump to go_router 17 with go_router_builder 4 - bump to retrofit_generator to 10.2
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| /// Location of the route. | ||
| final String location; | ||
| const ErrorRoute({required this.exception}); |
There was a problem hiding this comment.
Bug: ErrorRoute missing location property after refactoring
The location field was removed from ErrorRoute constructor, but the build method still passes location to ErrorPage. Since ErrorRoute extends GoRouteData directly without a generated mixin (like other routes use with $HomeRouteData), there's no location getter available. This will either cause a compile error or runtime failure when accessing location. The location should be obtained from state.uri.path in the build method instead.
🙌 What's Done
Flutter 3.38.4andDart 3.10Freezedand addEquatableinsteadaltive_lints 2.0.0-dev.3and removecustom_lintgo_router 17withgo_router_builder 4retrofit_generator 10.2dart formatandmelos run genslang 4.11and addslang_flutter 4.11and removeslang_build_runner✍️ What's Not Done
📝 Additional Notes
🖼️ Image Differences
Pre-launch Checklist
Note
Upgrades Flutter/Dart and tooling, replaces Freezed with Equatable across models, updates go_router/slang and generated code, consolidates routes, and adjusts CI/lints.
3.38.4and Dart3.10; refresh lockfile.go_routerto17(+go_router_builderv4),retrofit_generatorto10.2,slang/slang_flutterto4.11,altive_lintsto2.0.0-dev.3.analyzerandtest_apito support new generators.equatable+json_serializable(e.g.,RequestedVersionInfo,Todo, pub.dev client models) and remove generated*.freezed.dart.go_routerAPIs; consolidate branch routes intolib/router/app_routes.dartand regenerate mixin-based helpers; adjust error route.slang4.11; updated generated APIs and files (strings*.g.dart).assets.gen.dart) adding parameters likecolorMapperand animation metadata.custom_lint; adoptaltive_lintsplugin config; simplify GitHub Actions to analysis/format checks.Written by Cursor Bugbot for commit 870fd6b. This will update automatically on new commits. Configure here.