Skip to content

Conversation

@riscait
Copy link
Member

@riscait riscait commented Oct 23, 2025

🙌 What's Done

  • altfire_authenticator -> packages/core/authenticator
  • altfire_configurator -> packages/core/configurator
  • altfire_messenger-> packages/core/messenger
  • altfire_tracker -> packages/core/tracker

and

  • update Flutter to 3.35.6
  • create analysis_options.yaml on root
  • Created a new utils package to support the core packages
  • Translated Japanese comments to English across multiple files

✍️ What's Not Done

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@github-actions github-actions bot added documentation Improvements or additions to documentation flutter_app test themes labels Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 55.36232% with 154 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.15%. Comparing base (f6640bb) to head (dcec055).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ages/core/authenticator/lib/src/authenticator.dart 8.00% 46 Missing ⚠️
packages/core/tracker/lib/src/logger.dart 0.00% 29 Missing ⚠️
...re/authenticator/lib/src/google_authenticator.dart 4.54% 21 Missing ⚠️
...ore/authenticator/lib/src/phone_authenticator.dart 5.88% 16 Missing ⚠️
packages/core/messenger/lib/src/messenger.dart 73.46% 13 Missing ⚠️
...ore/authenticator/lib/src/apple_authenticator.dart 7.69% 12 Missing ⚠️
...ges/core/authenticator/lib/src/signing_method.dart 0.00% 7 Missing ⚠️
...ges/core/authenticator/lib/src/user_extension.dart 0.00% 6 Missing ⚠️
packages/core/tracker/lib/src/tracker.dart 96.42% 2 Missing ⚠️
...ckages/core/configurator/lib/src/configurator.dart 98.68% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #621       +/-   ##
===========================================
+ Coverage   29.10%   46.15%   +17.05%     
===========================================
  Files          15       27       +12     
  Lines         189      533      +344     
===========================================
+ Hits           55      246      +191     
- Misses        134      287      +153     
Files with missing lines Coverage Δ
...ges/core/authenticator/lib/src/auth_exception.dart 100.00% <100.00%> (ø)
packages/core/configurator/lib/src/config.dart 100.00% <100.00%> (ø)
...ate_requester/entities/requested_version_info.dart 100.00% <ø> (ø)
...utter_app/lib/util/extension/string_extension.dart 0.00% <ø> (ø)
...s/flutter_app/lib/util/logger/provider_logger.dart 12.00% <ø> (ø)
...ckages/core/configurator/lib/src/configurator.dart 98.68% <98.68%> (ø)
...er_provider_page/async_notifier_provider_page.dart 8.69% <0.00%> (ø)
packages/core/tracker/lib/src/tracker.dart 96.42% <96.42%> (ø)
...ges/core/authenticator/lib/src/user_extension.dart 0.00% <0.00%> (ø)
...ges/core/authenticator/lib/src/signing_method.dart 0.00% <0.00%> (ø)
... and 6 more
Components Coverage Δ
flutter_app 26.85% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6640bb...dcec055. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- altfire_authenticator -> packages/core/authenticator
- altfire_configurator -> packages/core/configurator
- altfire_messenger-> packages/core/messenger
- altfire_tracker -> packages/core/tracker

and
- update Flutter to 3.35.6
- create analysis_options.yaml on root
@riscait riscait force-pushed the replace-altfire-packages branch from 401d9e8 to 757bcec Compare October 23, 2025 07:19
@riscait riscait marked this pull request as ready for review October 23, 2025 07:20
@riscait riscait requested a review from a team as a code owner October 23, 2025 07:20
@riscait riscait requested review from Copilot, k-nkmr and naipaka and removed request for a team October 23, 2025 07:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the project by replacing external altfire_* packages with local workspace packages under packages/core/, updates Flutter to version 3.35.6, and creates a root-level analysis_options.yaml for shared linting configuration.

Key changes:

  • Replaced 4 external altfire packages (authenticator, configurator, messenger, tracker) with local workspace equivalents
  • Updated Flutter from 3.35.3 to 3.35.6
  • Centralized analysis options configuration at the project root
  • Created a new utils package to support the core packages
  • Translated Japanese comments to English across multiple files

Reviewed Changes

Copilot reviewed 93 out of 94 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pubspec.yaml Added new workspace package entries for core packages
packages/flutter_app/pubspec.yaml Replaced external altfire dependencies with local path dependencies and updated Firebase package versions
analysis_options.yaml Created root-level shared analysis configuration
packages/*/analysis_options.yaml Updated to include root analysis_options.yaml
packages/core/* Added new authenticator, configurator, messenger, tracker, and utils packages with implementations
packages/flutter_app/lib/**/*.dart Translated Japanese comments to English and updated import statements
.fvmrc, .vscode/settings.json Updated Flutter SDK version to 3.35.6

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riscait riscait added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 3747726 Oct 23, 2025
8 checks passed
@riscait riscait deleted the replace-altfire-packages branch October 23, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android documentation Improvements or additions to documentation flutter_app ios test themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants