-
Notifications
You must be signed in to change notification settings - Fork 29
refactor: replace altfire packages #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- altfire_authenticator -> packages/core/authenticator - altfire_configurator -> packages/core/configurator - altfire_messenger-> packages/core/messenger - altfire_tracker -> packages/core/tracker and - update Flutter to 3.35.6 - create analysis_options.yaml on root
401d9e8 to
757bcec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the project by replacing external altfire_* packages with local workspace packages under packages/core/, updates Flutter to version 3.35.6, and creates a root-level analysis_options.yaml for shared linting configuration.
Key changes:
- Replaced 4 external altfire packages (authenticator, configurator, messenger, tracker) with local workspace equivalents
- Updated Flutter from 3.35.3 to 3.35.6
- Centralized analysis options configuration at the project root
- Created a new
utilspackage to support the core packages - Translated Japanese comments to English across multiple files
Reviewed Changes
Copilot reviewed 93 out of 94 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Added new workspace package entries for core packages |
| packages/flutter_app/pubspec.yaml | Replaced external altfire dependencies with local path dependencies and updated Firebase package versions |
| analysis_options.yaml | Created root-level shared analysis configuration |
| packages/*/analysis_options.yaml | Updated to include root analysis_options.yaml |
| packages/core/* | Added new authenticator, configurator, messenger, tracker, and utils packages with implementations |
| packages/flutter_app/lib/**/*.dart | Translated Japanese comments to English and updated import statements |
| .fvmrc, .vscode/settings.json | Updated Flutter SDK version to 3.35.6 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
naipaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🙌 What's Done
and
✍️ What's Not Done
🖼️ Image Differences
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Pre-launch Checklist