-
Notifications
You must be signed in to change notification settings - Fork 29
build: bump Flutter to 3.35.3 #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Flutter to version 3.35.3 with Dart 3.9.2 and modernizes the dependency management system by transitioning from CocoaPods to Flutter's native dependency management with Swift Package Manager for iOS platforms.
- Removes CocoaPods dependencies and switches to Swift Package Manager
- Updates Firebase packages and resolves dependency conflicts
- Replaces deprecated DeviceFrameAddon with ViewportAddon in widget catalog
Reviewed Changes
Copilot reviewed 32 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Updates Flutter SDK version and removes dependency overrides |
| packages/flutter_app/pubspec.yaml | Updates Firebase packages and adds new Firebase services |
| packages/widget_catalog/lib/main.dart | Replaces DeviceFrameAddon with ViewportAddon |
| packages/flutter_app/ios/Podfile | Removes CocoaPods configuration entirely |
| packages/flutter_app/ios/ci_scripts/ci_post_clone.sh | Updates CI script to remove CocoaPods installation |
| .fvmrc | Updates Flutter version to 3.35.3 |
Files not reviewed (1)
- packages/flutter_app/ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| itemBuilder: (_, index) { | ||
| final themeMode = ThemeMode.values[index]; | ||
| return RadioListTile<ThemeMode>( | ||
| value: themeMode, |
Copilot
AI
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RadioListTile is missing the groupValue and onChanged properties after being wrapped in RadioGroup. These properties should be removed from individual RadioListTiles when using RadioGroup as the parent handles the group behavior.
naipaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 What's Done
✍️ What's Not Done
📝 Additional Notes
Pre-launch Checklist