Skip to content

Conversation

@riscait
Copy link
Member

@riscait riscait commented Sep 12, 2025

🙌 What's Done

  • Flutter 3.35.3 with Dart 3.9.2
    • Use RadioGroup
    • Resolve the dependencies of the Firebase package
  • Update to altive_lints 1.23.0 with custom_lint 0.8.0
  • Update to Melos v7.1
  • Remove CocoaPods from flutter_app
  • Remove dependency_overrides
  • Update CodeCov settings
  • Add CONTRIBUTING.md
  • Fix widget_catalog
    • DeviceFrameAddon to ViewportAddon

✍️ What's Not Done

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code (e.g., updated tests and documentation)

@github-actions github-actions bot added documentation Improvements or additions to documentation flutter_app ios themes labels Sep 12, 2025
@github-actions github-actions bot added the macos label Sep 12, 2025
@riscait riscait marked this pull request as ready for review September 12, 2025 07:58
@riscait riscait requested a review from a team as a code owner September 12, 2025 07:58
@riscait riscait requested review from Copilot, k-nkmr and naipaka and removed request for a team September 12, 2025 07:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Flutter to version 3.35.3 with Dart 3.9.2 and modernizes the dependency management system by transitioning from CocoaPods to Flutter's native dependency management with Swift Package Manager for iOS platforms.

  • Removes CocoaPods dependencies and switches to Swift Package Manager
  • Updates Firebase packages and resolves dependency conflicts
  • Replaces deprecated DeviceFrameAddon with ViewportAddon in widget catalog

Reviewed Changes

Copilot reviewed 32 out of 36 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pubspec.yaml Updates Flutter SDK version and removes dependency overrides
packages/flutter_app/pubspec.yaml Updates Firebase packages and adds new Firebase services
packages/widget_catalog/lib/main.dart Replaces DeviceFrameAddon with ViewportAddon
packages/flutter_app/ios/Podfile Removes CocoaPods configuration entirely
packages/flutter_app/ios/ci_scripts/ci_post_clone.sh Updates CI script to remove CocoaPods installation
.fvmrc Updates Flutter version to 3.35.3
Files not reviewed (1)
  • packages/flutter_app/ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

itemBuilder: (_, index) {
final themeMode = ThemeMode.values[index];
return RadioListTile<ThemeMode>(
value: themeMode,
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RadioListTile is missing the groupValue and onChanged properties after being wrapped in RadioGroup. These properties should be removed from individual RadioListTiles when using RadioGroup as the parent handles the group behavior.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit f6640bb Sep 16, 2025
9 checks passed
@riscait riscait deleted the flutter-3353 branch September 16, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation flutter_app ios macos themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants