adds self.run_forever_flag to streams#501
Open
0xfMissingNo wants to merge 1 commit intoalpacahq:masterfrom
Open
adds self.run_forever_flag to streams#5010xfMissingNo wants to merge 1 commit intoalpacahq:masterfrom
0xfMissingNo wants to merge 1 commit intoalpacahq:masterfrom
Conversation
ec75f00 to
0b4cae4
Compare
f3c281b to
83a1f00
Compare
haxdds
reviewed
Nov 15, 2021
| from .stream2 import StreamConn # noqa | ||
|
|
||
| __version__ = '1.4.0' | ||
| __version__ = '1.4.1' |
Contributor
There was a problem hiding this comment.
Hi 0xfMissingNo! Version changes are necessary in your PR. They are made when we release and deploy a new version.
| self._ws = None | ||
| self._running = False | ||
| self._stop_stream_queue = queue.Queue() | ||
| self._run_forever_flag = False |
Contributor
There was a problem hiding this comment.
What is the purpose of this flag? What functionality does it add over while True?
haxdds
reviewed
Nov 15, 2021
| print('keyboard interrupt, bye') | ||
| pass | ||
|
|
||
| async def _close(self): |
Contributor
There was a problem hiding this comment.
Thanks for taking the time to contribute! To help us out, could you please elaborate a bit further on the goal of your PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wanted to handle async loops from a separate thread if need be; pushing my patch upstream: