removed tasks.loop & added call_later for better task scheduling

tux/cogs/utility/remindme.py

@@ -1,8 +1,9 @@
+import asyncio
 import contextlib
 import datetime
 
 import discord
-from discord.ext import commands, tasks
+from discord.ext import commands
 from loguru import logger
 
 from prisma.models import Reminder
@@ -16,25 +17,11 @@
     def __init__(self, bot: Tux) -> None:
         self.bot = bot
         self.db = DatabaseController()
-        self.check_reminders.start()
         self.remindme.usage = generate_usage(self.remindme)
-
-    @tasks.loop(seconds=120)
-    async def check_reminders(self):
-        reminders = await self.db.reminder.get_unsent_reminders()
-
-        try:
-            for reminder in reminders:
-                await self.send_reminder(reminder)
-                await self.db.reminder.update_reminder_status(reminder.reminder_id, sent=True)
-                logger.debug(f'Status of reminder {reminder.reminder_id} updated to "sent".')
-
-        except Exception as e:
-            logger.error(f"Error sending reminders: {e}")
+        self._initialized = False
 
     async def send_reminder(self, reminder: Reminder) -> None:
         user = self.bot.get_user(reminder.reminder_user_id)
-
         if user is not None:
             embed = EmbedCreator.create_embed(
                 bot=self.bot,
@@ -69,9 +56,29 @@
                 f"Failed to send reminder {reminder.reminder_id}, user with ID {reminder.reminder_user_id} not found.",
             )
 
-    @check_reminders.before_loop
-    async def before_check_reminders(self):
-        await self.bot.wait_until_ready()
+        try:
+            await self.db.reminder.delete_reminder_by_id(reminder.reminder_id)
+        except Exception as e:
+            logger.error(f"Failed to delete reminder: {e}")
+
+    @commands.Cog.listener()
+    async def on_ready(self) -> None:
+        if self._initialized:
+            return
+
+        self._initialized = True
+
+        reminders = await self.db.reminder.get_all_reminders()
+        dt_now = datetime.datetime.now(datetime.UTC)
+
+        for reminder in reminders:
+            seconds = (reminder.reminder_expires_at - dt_now).total_seconds()
+
+            if seconds <= 0:
+                await self.send_reminder(reminder)
+                continue
+
+            self.bot.loop.call_later(seconds, asyncio.create_task, self.send_reminder(reminder))
 
     @commands.hybrid_command(
         name="remindme",
@@ -120,14 +127,16 @@
         expires_at = datetime.datetime.now(datetime.UTC) + datetime.timedelta(seconds=seconds)
 
         try:
-            await self.db.reminder.insert_reminder(
+            reminder_obj = await self.db.reminder.insert_reminder(
                 reminder_user_id=ctx.author.id,
                 reminder_content=reminder,
                 reminder_expires_at=expires_at,
                 reminder_channel_id=ctx.channel.id if ctx.channel else 0,
                 guild_id=ctx.guild.id if ctx.guild else 0,
             )
 
+            self.bot.loop.call_later(seconds, asyncio.create_task, self.send_reminder(reminder_obj))
+
             embed = EmbedCreator.create_embed(
                 bot=self.bot,
                 embed_type=EmbedCreator.SUCCESS,
@@ -139,8 +148,7 @@
 
             embed.add_field(
                 name="Note",
-                value="- If you have DMs closed, we will attempt to send it in this channel instead.\n"
-                "- The reminder may be delayed by up to 120 seconds due to the way Tux works.",
+                value="- If you have DMs closed, we will attempt to send it in this channel instead.\n",
             )
 
         except Exception as e:

tux/database/controllers/reminder.py

@@ -1,4 +1,4 @@
-from datetime import UTC, datetime
+from datetime import datetime
 
 from prisma.actions import GuildActions
 from prisma.models import Guild, Reminder
@@ -43,20 +43,6 @@
         """
         return await self.find_unique(where={"reminder_id": reminder_id})
 
-    async def get_unsent_reminders(self) -> list[Reminder]:
-        """Get all unsent reminders that have expired.
-
-        This method finds reminders that should be sent to users
-        because their expiration time has passed.
-
-        Returns
-        -------
-        list[Reminder]
-            List of unsent expired reminders
-        """
-        now = datetime.now(UTC)
-        return await self.find_many(where={"reminder_sent": False, "reminder_expires_at": {"lte": now}})
-
     async def insert_reminder(
         self,
         reminder_user_id: int,