This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Added MMapIndexedCache#4611
Open
OhadRubin wants to merge 3 commits intoallenai:mainfrom
OhadRubin:master
Open
Conversation
OhadRubin
commented
Aug 27, 2020
Contributor
Author
|
Hey, @epwalsh, i'm in the process of adapting the original fairseq code to our needs. |
Member
|
Hey @OhadRubin, is there any reason why the |
Contributor
Author
|
No, that's one of the things from fairseq I kinda want to change... |
Contributor
Author
|
Btw, during instance creation, is it possible to require that all fields exists, this will really help deserialization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4591
This is a really rough draft...