Merged
Conversation
✅ Deploy Preview for tealscript ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for bitwise operations on byte inputs by introducing new functions in the contract, updating ABI artifacts and TEAL code, and adding corresponding opcodes in the compiler.
- Added contract methods for bitwise XOR, AND, OR, and NOT in tests/contracts/binary.algo.ts.
- Updated ABI JSON definitions and TEAL approval logic to support the new bitwise operations.
- Updated the snapshot and compiler opcode mappings to reflect these changes.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/contracts/binary.algo.ts | Added wrapper functions calling bitwise operations on bytes. |
| tests/contracts/artifacts/*.json | Updated ABI artifacts to include new bitwise operation methods. |
| tests/contracts/artifacts/BinaryTest.approval.teal | Added new subroutines and abi routes for bitwise op methods. |
| tests/snapshots/binary.test.ts.snap | Updated snapshot reflecting the new program size. |
| src/lib/compiler.ts | Introduced new opcode mappings for bitwise operations. |
Comments suppressed due to low confidence (2)
src/lib/compiler.ts:6944
- Consider adding inline documentation for the new bitwise opcodes (bitwiseXor, bitwiseAnd, bitwiseOr, bitwiseNot) to clarify their behavior and mapping to TEAL instructions.
bitwiseXor: 'b^',
tests/snapshots/binary.test.ts.snap:3
- [nitpick] Verify that the updated snapshot reflecting an increased program size is intended and that it covers the changes introduced by the new bitwise operations.
exports[`Binary Expressions BinaryTest Artifacts Maintains program size 1`] = `461`;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #586