feat(a11y): visual hint for keyboard navigation#2806
Open
ramiy wants to merge 2 commits intoalgolia:mainfrom
Open
feat(a11y): visual hint for keyboard navigation#2806ramiy wants to merge 2 commits intoalgolia:mainfrom
ramiy wants to merge 2 commits intoalgolia:mainfrom
Conversation
ramiy
requested review from
8bittitan,
NatanTechofNY,
dylantientcheu,
pipeline1987,
shortcuts and
vascobettencourt
as code owners
👷 Deploy request for docsearch pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for docsearch-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve accessibility, there should be a visual indicator on buttons.
Check the following screenshots with the accessibility tree active on dev tools. When you hover over a button, it has a blue visual indicator, but when you navigate with a keyboard (using the
TABandSHIFT+TABkeys), the focused button has no visual indicator.Hover with a mouse:
Navigate with a keyboard:
