Use Decodable where enough for search#874
Open
michallaskowski wants to merge 1 commit intoalgolia:mainfrom
Open
Use Decodable where enough for search#874michallaskowski wants to merge 1 commit intoalgolia:mainfrom
michallaskowski wants to merge 1 commit intoalgolia:mainfrom
Conversation
Ferchmin
approved these changes
Dec 13, 2024
mpawlo
approved these changes
Dec 13, 2024
Author
|
Will open where needed in the main repo once I find that place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
In process of upgrading to v9 I noticed that there was a change that search results should be
Codable, instead of justDecodable. Seems unnecessary since they are not stored in any place, just had to replace generics in Search client and it builds.Under the hood it uses
Transporter.send<T: Decodable>anyway.