Fix checkpayment tests #847
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliel
requested review from
nesitor and
odesenfans
and removed request for
nesitor and
odesenfans
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 64.85% 64.82% -0.03%
==========================================
Files 88 88
Lines 8163 8159 -4
Branches 734 734
==========================================
- Hits 5294 5289 -5
- Misses 2639 2641 +2
+ Partials 230 229 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aliel
force-pushed
the
aliel-fix-ci
branch
10 times, most recently
from
0b348ad to
72890e7
Compare
…ble use another CCN URL to try to connect it." Fix: Refactor API failover to prevent test timeouts
aliel
force-pushed
the
aliel-fix-ci
branch
2 times, most recently
from
cd63201 to
ff48e9f
Compare
aliel
force-pushed
the
aliel-fix-ci
branch
2 times, most recently
from
00fb772 to
35b842b
Compare
This reverts commit d58b1f3.
… when mounting the base image.
odesenfans
reviewed
Nov 10, 2025
| await execution.start() | ||
| await execution.stop() | ||
| await asyncio.wait_for(execution.start(), timeout=300) | ||
| await asyncio.wait_for(execution.stop(), timeout=300) |
| mkdir -p /opt/aleph/libs | ||
| # Fixing this protobuf dependency version to avoid getting CI errors as version 5.29.0 have this compilation issue. | ||
| pip3 install --target /opt/aleph/libs 'aleph-sdk-python==2.0.5' 'aleph-message~=1.0.5' 'fastapi~=0.120.1' 'protobuf==6.33.0' | ||
| pip3 install --target /opt/aleph/libs 'aleph-sdk-python==2.0.0' 'aleph-message~=1.0.5' 'fastapi~=0.121.0' 'protobuf==5.28.3' |
Contributor
There was a problem hiding this comment.
I don't think this needs to be changed by this PR. Revert?
| return 500 * len(executions) | ||
|
|
||
| mocker.patch("aleph.vm.orchestrator.tasks.compute_required_flow", compute_required_flow) | ||
| mocker.patch("aleph.vm.orchestrator.tasks.compute_required_flow", new=compute_required_flow) |
Contributor
There was a problem hiding this comment.
Not sure this change is pertinent, it's more confusing than anything. I had to look up the doc to understand that new= was the second argument and that therefore this change changes nothing.
| mocker.patch( | ||
| "aleph.vm.orchestrator.tasks.get_community_wallet_address", | ||
| new=mocker.AsyncMock(return_value=mock_community_wallet_address), | ||
| ) |
Contributor
There was a problem hiding this comment.
What's the difference in behavior with
mocker.patch("aleph.vm.orchestrator.tasks.get_community_wallet_address", return_value=mock_community_wallet_address)
? I don't think there's one.
| return {"result": False, "reason": str(e)} | ||
| except Exception as e: | ||
| logger.error(f"Unexpected error in URL check: {e}", exc_info=True) | ||
| return {"result": False, "reason": str(e)} |
Contributor
There was a problem hiding this comment.
This is reimplementing what Andres did in another way right? Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests was hanging because async mocks was not correctly configure