🛡️ Sentinel: Fix Stored XSS in Markdown Parser #58
+16
−81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel Report: Stored XSS Fix
Vulnerability:
The
ArticlePage.tsxcomponent used a custom regex-based markdown parser that directly injected HTML into the DOM viadangerouslySetInnerHTML. The parser lacked input sanitization, allowing attackers (or malicious content sources) to break out of generated tags (e.g., using</pre><script>...) and execute arbitrary JavaScript.Fix:
Implemented an
escapeHtmlfunction that converts special characters (&,<,>,",') to their HTML entities. This function is applied to the raw article content before any markdown processing occurs.Impact:
print("<div>")renders as visible text).PR created automatically by Jules for task 16053209843193932100 started by @albertoivo