Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR introduces a useFocusTrap hook to improve accessibility in modals, specifically applied to the TutorialModal component.

💡 What:

  • Created src/hooks/useFocusTrap.ts which manages focus trapping (keeping focus inside the modal), handles the Escape key, and restores focus to the trigger element when closed.
  • Updated src/components/education/TutorialModal.tsx to utilize this hook.
  • Added src/__tests__/useFocusTrap.test.tsx to verify the behavior.

🎯 Why:

  • Previous implementation of TutorialModal allowed keyboard users to tab out of the modal, getting lost in the background content.
  • It also lacked standard "Escape to close" behavior in some contexts (though StoryModal had it locally).
  • Focus restoration is a WCAG requirement so users know where they are after closing a dialog.

Accessibility:

  • Focus Trap: Prevents focus from leaking to the background.
  • Escape Key: Allows easy closure of the modal.
  • Focus Restoration: Returns focus to the element that opened the modal.
  • Initial Focus: Ensures screen readers start reading the modal content correctly.

PR created automatically by Jules for task 10959579840997538626 started by @albertoivo

- Implements useFocusTrap hook to handle Tab cycling, Shift+Tab leak prevention, and Escape key closing.
- Updates TutorialModal to use useFocusTrap.
- Adds comprehensive tests for useFocusTrap.
- Fixes accessibility issue where keyboard users could tab out of modals.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@albertoivo albertoivo closed this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant