Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR updates the Content Security Policy (CSP) in firebase.json to explicitly allow iframes from github.com. This is required for the 'GitHub Sponsors' card on the About Page, which was previously blocked by the default policy (or lack of frame-src). This aligns the security configuration with the application's functionality as verified by tests.


PR created automatically by Jules for task 8662945522178517116 started by @albertoivo

- Added `frame-src 'self' https://github.com;` to `firebase.json` CSP.
- Verified that `AboutPage` requires this iframe via `AboutPage.test.tsx`.
- Updated Sentinel journal with learning about aligning CSP with code requirements.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 8d8d9eb):

https://pyexplorer-cd32d--pr125-sentinel-csp-fix-866-g9s6whol.web.app

(expires Sun, 01 Feb 2026 18:33:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61

@albertoivo albertoivo marked this pull request as ready for review January 26, 2026 11:58
@albertoivo albertoivo merged commit 804df84 into main Jan 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant