refactor(dx): replace loadWithPagination with getAllItems#2942
refactor(dx): replace loadWithPagination with getAllItems#2942
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
8a64763 to
0057fbc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
==========================================
- Coverage 57.79% 57.78% -0.01%
==========================================
Files 1019 1019
Lines 23675 23669 -6
Branches 5861 5864 +3
==========================================
- Hits 13682 13677 -5
+ Misses 8707 8701 -6
- Partials 1286 1291 +5
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Replace all usages of the deprecated loadWithPagination utility with getAllItems from @akashnetwork/http-sdk, which includes circular loop detection. Remove dead loadWithPagination code from deploy-web, http-sdk, and indexer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0057fbc to
e3bd9e2
Compare
Why
loadWithPaginationis deprecated in favor ofgetAllItemsfrom@akashnetwork/http-sdkgetAllItemsincludes circular loop detection, preventing infinite pagination loopsWhat
loadWithPaginationwithgetAllItemsfrom@akashnetwork/http-sdkin:apps/deploy-web/src/queries/useDeploymentQuery.tsapps/deploy-web/src/queries/useGrantsQuery.tsapps/deploy-web/src/queries/useLeaseQuery.tsapps/deploy-web/src/services/wallet-balances/wallet-balances.service.tspackages/http-sdk/src/deployment/deployment-http.service.tsloadWithPaginationandhasQueryParamfrom:apps/deploy-web/src/utils/apiUtils.tspackages/http-sdk/src/utils/pagination.utils.tsloadWithPaginationcode fromapps/indexer/src/shared/utils/query.ts